feat: Add a little bit of typing to google.api_core.retry#453
feat: Add a little bit of typing to google.api_core.retry#453parthea merged 3 commits intogoogleapis:mainfrom asottile-sentry:type-retry-a-bit
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
| """ | ||
|
|
||
| from __future__ import unicode_literals | ||
| from __future__ import annotations |
There was a problem hiding this comment.
this library has python_requires >= 3.7 so (1) unicode_literals does nothing and (2) this is the first version which supports __future__.annotations
it might be a good idea to run https://github.com/asottile/pyupgrade on this codebase to remove the remaining python 2isms
There was a problem hiding this comment.
Thanks! I've captured this TODO in https://github.com/googleapis/python-api-core/issues/524
|
👋 I've rebased this to resolve conflicts (again) -- could it get reviewed? |
parthea
changed the title
parthea
left a comment
parthea
left a comment
There was a problem hiding this comment.
Thanks @asottile-sentry!
| """ | ||
|
|
||
| from __future__ import unicode_literals | ||
| from __future__ import annotations |
There was a problem hiding this comment.
Thanks! I've captured this TODO in https://github.com/googleapis/python-api-core/issues/524
parthea
added
the
automerge: exact
gcf-merge-on-green
bot
dismissed
parthea’s stale review
This review does not reference the most recent commit, and you are using the secure version of merge-on-green. Please re-review the most recent commit.
gcf-merge-on-green
bot
removed
the
automerge: exact
2 participants
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: